Skip to content

Class Env::CleanupHook should be public #1238

@julianmesa-gitkraken

Description

@julianmesa-gitkraken

I have created a Cleanup hook using env.AddCleanupHook(cleanup, this) but I cannot store the hook in a member var because the class Env::CleanupHook is private.
So I cannot remove the hook calling to Remove function.
I make it public to test my app and works perfect the only issue is that I think it will be a good idea to create an empty default contructor so we can create a member class var without issue.
I can create a PR making this class public, but not sure why this class was designed to be private.

Also found an error in line 361
Then #endif should be betwen lines 359 - 360

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions