Closed
Conversation
mhdawson
approved these changes
Aug 27, 2021
Member
mhdawson
left a comment
There was a problem hiding this comment.
LGTM once commit comment is updated to indicates that all non file-renames are due to fixes issues reported by linter when file was renamed.
NickNaso
approved these changes
Sep 2, 2021
Member
NickNaso
left a comment
There was a problem hiding this comment.
LGTM. Could you please add little description about what this PR do. This could help us in the future.
Member
|
@deepakrkris just waiting for the updates to the comments before landing. |
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors
c66e2fa to
733d91a
Compare
Contributor
Author
|
@mhdawson @NickNaso @gabrielschulhof @KevinEady, |
Member
|
@deepakrkris thanks, landing now |
mhdawson
pushed a commit
that referenced
this pull request
Sep 9, 2021
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: #1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Member
|
Landed as cbac3aa |
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Sep 23, 2021
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Oct 15, 2021
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs/node-addon-api#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs/node-addon-api#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs/node-addon-api#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs/node-addon-api#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.