PR-URL: nodejs#937
Reviewed-By: Michael Dawson <midawson@redhat.com>

* doc: fix tab indent

…odejs#929)

* Fixes issue 258.

Added windows-2016 as virtual environment.

PR-URL: nodejs#948
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

Also fixed lint errors.

Fixes: nodejs#952
PR-URL: nodejs#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

Done by running:
sed -i "s/N-API/Node-API/g" doc/*
sed -i "s/N-API/Node-API/g" README.md CONTRIBUTING.md

Fixes: nodejs#950
PR-URL: nodejs#951
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

Currently, deprecation notices are always right between two function
signatures and it's virtually impossible to be certain whether they
refer to the previous signature or the next signature.

PR-URL: nodejs#942
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#939
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#955
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#974
Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#973
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#976
Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#1005
Reviewed-By: Michael Dawson <midawson@redhat.com>

Fixes: nodejs#1007

PR-URL: nodejs#1009
Reviewed-By: Michael Dawson <midawson@redhat.com>

When terminating an environment (e.g., by calling worker.terminate),
napi_throw, which is called by Error::ThrowAsJavaScriptException,
returns napi_pending_exception, which is then incorrectly treated as
a fatal error resulting in a crash.

PR-URL: nodejs#975
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#1004
Reviewed-By: Michael Dawson <midawson@redhat.com>

Fixes: nodejs#1011

PR-URL: nodejs#1013
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: nodejs#1015
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>

PR-URL: nodejs#972
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>

Throw an exception when receiving a null pointer for the `char *` and
`char16_t *` overloads of `String::New` that looks identical to an
error that core would have thrown under the circumstances
(`napi_invalid_arg`).

Also, rename the test methods to conform with our naming convention.

PR-URL: nodejs#1019
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

fixes: nodejs#1022

The objectwrap_worker_thread and symbol tests
were not waiting for the test to complete before the
subsequent tests were started. This caused intermitted
crashes in the CI.

Updated both tests so that they complete before the
next test runs.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#1024
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Add CleanupHook support to Env

PR-URL: nodejs#1014
Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#927
Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs#1061
Reviewed-By: Michael Dawson <midawson@redhat.com>

* doc: fixed doc about how to enable C++ exceptions.

PR-URL: nodejs#1059
Reviewed-By: Michael Dawson <midawson@redhat.com>

- fix error reported about possible use of
  un-initialized variable from newer compiler

Signed-off-by: Michael Dawson <mdawson@devrus.com>

- change all unit test file names to snake case
  this helps in parsing file names to tokens and infer metadata
  like export initializers

- all other changes other than file names is due to linter errors

PR-URL: nodejs#1056
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>

PR-URL: nodejs#1055
Reviewed-By: Michael Dawson <midawson@redhat.com>

I guess if these were broken in practice, V8/Node.js itself would also
experience difficulties with it, but there’s no real reason not to use
the proper alternatives.

PR-URL: nodejs#1070
Reviewed-By: Michael Dawson <midawson@redhat.com>

Function::New fails to compile when given a move-only functor. For
example, when constructing a callback function for Promise#then, a
lambda might capture an ObjectReference. Creating a Function for such a
lambda results in a compilation error.

Tweak Function::New to work with move-only functors.

For existing users of Function::New, this commit should not change
behavior.

* lint: add eslint based on config-semistandard