Codecov Report

Merging #215 (68310b7) into master (d777940) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   80.53%   80.70%   +0.17%     
==========================================
  Files          11       11              
  Lines         822      819       -3     
  Branches      252      251       -1     
==========================================
- Hits          662      661       -1     
+ Misses         69       68       -1     
+ Partials       91       90       -1     

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth your comment in that closed PR

However, as I type that, I realize they have put in tests to make sure that doesn't happen...

Remember that node-saml has its own test for "multiple roots" to ensure that even if xmldom makes some stupid change, tests in this projects will catch it, see: https://github.com/node-saml/node-saml/blob/master/test/test-signatures.spec.ts#L72-L77

That test will fail if xmldom is not causing that error what test is expecting. Error is thrown over here https://github.com/node-saml/node-saml/blob/master/src/xml.ts#L190

(and it is best that node-saml is not "translating" those xmldom errors to our own versions)