Fix #207, updated @xmldom/xmldom and xml-crypto packages - #209
Closed
RopoMen wants to merge 1 commit into
Closed
Conversation
…the latest versions.
Contributor
Author
|
This fixes also PR #205 |
Collaborator
RopoMen
commented
Nov 15, 2022
| ) { | ||
| return reject(new Error("Malformed XML; multiple roots detected")); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@cjbarth I noticed that you already merged another PR which updated xmldom. That is ok, but I noticed that there was added comment https://github.com/node-saml/node-saml/blob/master/src/xml.ts#L217
My opinion is that that is dead code that should be removed.
Collaborator
There was a problem hiding this comment.
I was thinking about it, then I realized that this code actually protects against a vulnerability and was torn about removing it and then potentially a dependency reintroduces the problem and we are vulnerable again. However, as I type that, I realize they have put in tests to make sure that doesn't happen, so we probably should just remove the old code. I'll create another PR for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
Fixed unit test, because now xmldom detects multiple roots.