Release 2.1.0 - #331
Closed
Nikitha Chettiar (nikithauc) wants to merge 20 commits into
Closed
Conversation
updated broken link in README
…oftgraph/msgraph-sdk-javascript into abhsriva/emptyPostRequest
Post request with empty body, now working fine.
Simplify building middleware chain
Updated GraphRequest.ts to handle .count() when no parameter is specified
Updated GraphRequest.ts for .count() scenario
Vincent Biret (baywet)
suggested changes
Sep 30, 2020
|
|
||
| export const serializeContent = (content: any): any => { | ||
| const className: string = content.constructor.name; | ||
| const className: string = content === undefined ? undefined : content.constructor.name; |
There was a problem hiding this comment.
Suggested change
| const className: string = content === undefined ? undefined : content.constructor.name; | |
| const className: string = content && content.constructor && content.constructor.name; |
Contributor
Author
There was a problem hiding this comment.
Done.
…tgraph/msgraph-sdk-javascript into nikithauc/Release-2.1.0
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Member
|
Nikitha Chettiar (@nikithauc) can I assume this one is replaced by #333 ? |
Contributor
Author
|
Vincent Biret (@baywet) #333 is not a replacement. There will another PR for release2.1.0 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping the version to 2.1.0 for changes in 2.1.0-Preview.1