Post request with empty body, now working fine. - #229
Merged
Conversation
Abhinav Srivastava (krototype)
requested review from
Mohamed Bilal A (bilalgce) and
Muthurathinam (muthurathinam)
September 16, 2019 05:44
|
Looks good to me. Please pull latest changes into this branch. |
Mohamed Bilal A (bilalgce)
left a comment
There was a problem hiding this comment.
Please pull latest changes from dev into this branch
Abhinav Srivastava (krototype)
requested a review
from Mohamed Bilal A (bilalgce)
September 16, 2019 09:06
Muthurathinam (muthurathinam)
approved these changes
Sep 21, 2019
Muthurathinam (muthurathinam)
left a comment
Contributor
There was a problem hiding this comment.
Looks Good.
Darrel (darrelmiller)
approved these changes
Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST request with the empty body are possible for some situations, according to the graph. Made changes for the SDK to work for the same.
Motivation
Received an issue, where POST request with the empty body was working fine.
Closing issues
Fixes #225
Types of changes
Checklist