removes duplicated code for http provider - #455
Merged
Vincent Biret (baywet) merged 25 commits intoOct 7, 2020
Conversation
Contributor
|
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
Contributor
|
Conflicts have been resolved. A maintainer will take a look shortly. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Conflicts have been resolved. A maintainer will take a look shortly. |
Contributor
|
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
I'm adding a feature request to GH to turn off notifications while a PR is in draft state. So I setup custom notification setting to see if it will turn off commit emails until you assign me as reviewer:
I think just by posting this it is considered participation and I will continue to get emails so I will reset. I'll let you. |
Vincent Biret (baywet)
marked this pull request as ready for review
October 7, 2020 17:02
Vincent Biret (baywet)
requested review from
Michael Mainer (MIchaelMainer),
DeVere Dyett (ddyett) and
Nikitha Chettiar (nikithauc)
October 7, 2020 17:02
Michael Mainer (MIchaelMainer)
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #202
fixes #516
fixes #517
Changes proposed in this pull request
Other links