Skip to content

Send attachment with mail - #202

Merged
Vincent Biret (baywet) merged 10 commits into
devfrom
attachment-bug-fix
Sep 9, 2020
Merged

Send attachment with mail#202
Vincent Biret (baywet) merged 10 commits into
devfrom
attachment-bug-fix

Conversation

@NakulSabharwal

@NakulSabharwal NakulSabharwal commented Jan 6, 2019

Copy link
Copy Markdown
Contributor

Fixes #192
Fixes #90

Changes proposed in this pull request

  • Serializer for attachments.
  • Tests for sending attachment with email.
  • Expose attachment attribute

@github-actions

This comment has been minimized.

@baywet Vincent Biret (baywet) added this to the 2.0.1 milestone Sep 2, 2020
@github-actions

github-actions Bot commented Sep 4, 2020

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will take a look shortly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed online with Vincent

@baywet
Vincent Biret (baywet) merged commit dd7778c into dev Sep 9, 2020
@baywet
Vincent Biret (baywet) deleted the attachment-bug-fix branch September 9, 2020 15:44
@Przemek-12

Przemek-12 commented Oct 2, 2020

Copy link
Copy Markdown

Hi, I can't send mail message with attachment. I use exact same code as in unit tests. I get NoSuchMethodException at CollectionPageSerializer class, line 84.
java.lang.NoSuchMethodError: 'com.google.gson.JsonElement com.google.gson.JsonParser.parseString(java.lang.String)'.
In JsonParser class, there's no parseString method. There's only parse(String json).

@baywet

Copy link
Copy Markdown
Member

hi Przemek-12
Can you open a separate issue please so it's easier for us to have a focused discussion?
Thanks!

@Przemek-12

Copy link
Copy Markdown

hi, just opened it: #515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to send attachment with this API https://graph.microsoft.com/v1.0/me/sendMail send email with attachments

4 participants