Skip to content

Use the CppWinRTPlatformWinMDReferences itemgroup as the input for the platform projection. - #774

Merged
Johan Laanstra (jlaanstra) merged 1 commit into
masterfrom
user/jlaans/773
Oct 20, 2020
Merged

Use the CppWinRTPlatformWinMDReferences itemgroup as the input for the platform projection.#774
Johan Laanstra (jlaanstra) merged 1 commit into
masterfrom
user/jlaans/773

Conversation

@jlaanstra

@jlaanstra Johan Laanstra (jlaanstra) commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

Fixes #773

TODO

  • Validate razzle build.

@jlaanstra

Copy link
Copy Markdown
Contributor Author

Validated the razzle build after reverting #742

@DHowett

Copy link
Copy Markdown
Member

terminal is seeing some build failures due to platform types missing when transitively used in projects that depend on winmds produced by other components with the latest version; could this be related?

MDMERGE : error MDM2002: The type "Windows.Foundation.IReference`1" defined in file Microsoft.Terminal.TerminalControl.winmd was referenced by type Microsoft.Terminal.TerminalControl.ICoreSettings but could not be found. [src\cascadia\UnitTests_TerminalCore\UnitTests.vcxproj]

cppwinrt : error Type 'Windows.Foundation.EventRegistrationToken' could not be found
 method: TerminalOutput
 type: Microsoft.Terminal.TerminalConnection.ITerminalConnection
 database: C:\Users\Dustin\src\terminal\x64\Release\TerminalConnection\Microsoft.Terminal.TerminalConnection.w
inmd

@DHowett

Copy link
Copy Markdown
Member

(Rolling back one version to 2.0.201017.1 fixes our build. 2.0.201026 is broken; this seems to be the only changeset that addresses platform winmds in the new version.)

@jlaanstra

Johan Laanstra (jlaanstra) commented Oct 27, 2020

Copy link
Copy Markdown
Contributor Author

Dustin L. Howett (@DHowett) can you share a binlog from your build? Happy to take a look. You can probably apply the same fix from #781 to get unblocked as your unit test project is probably not targeting UAP and so the default targets don't add the WinMDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build targets pass a separate list of reference to MIDL then they generate a platform projection for.

3 participants