Targets that add compiler options must run before FixupCLCompileOptions - #742
Merged
Kenny Kerr (kennykerr) merged 4 commits intoSep 15, 2020
Merged
Conversation
Member
Author
|
CC Kenny Kerr (@kennykerr). Looks like the C++ for WinRT Xlang internal Build task is stuck, mind kicking it? |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
I just need Scott Jones (@Scottj1s) or Johan Laanstra (@jlaanstra) to review the msbuild goo. |
Member
Author
|
CC Yue (Felix) Huang (@yuehuang010) Olga Arkhipova (@olgaark) to double check me |
Alexander Sklar (asklar)
marked this pull request as draft
September 14, 2020 04:49
Alexander Sklar (asklar)
marked this pull request as ready for review
September 14, 2020 07:39
Johan Laanstra (jlaanstra)
approved these changes
Sep 14, 2020
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
|
This change breaks the razzle build with |
Merged
1 task
Contributor
|
Turns out this is actually a bug in razzle. I'll send mail with details since this is a problem with an internal tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #741
This is hit when forcing proc count in msbuild since /MP should also imply /FS (force synchronous writes) but that enforcement is done by
FixupCLCompileOptionsafter all otherComputeCompileInputsTargetsruns. If something runs after the fix up has already happened, we break the build (Error C1041: cannot open program database)