Generate test failure output on abnormal termination - #1011
Merged
Conversation
Merged
Collaborator
|
Thanks David! Why don't you add the https://github.com/microsoft/cppwinrt/pull/1009/files That will verify whether the CI build fails visibly or silently. Once that has been confirmed, just remove the |
Collaborator
Contributor
Author
|
It's worse than that - even normal test failures don't cause the pipeline to fail (see my latest commit in this PR and the corresponding run). I've sent email to the team to discuss. |
David Fields (dfields-msft)
force-pushed
the
user/dfields/report-fatal
branch
from
September 7, 2021 22:25
4fc1201 to
7afc84c
Compare
…e test executable exits successfully
David Fields (dfields-msft)
force-pushed
the
user/dfields/report-fatal
branch
from
September 7, 2021 22:50
7afc84c to
fd0b747
Compare
Contributor
Author
Contributor
Author
|
Logged #1012 on an unrelated test failure that passed on rerun (also passed on both x86 runs); this may have been masked for some time due to the lack of failure reporting in the build pipeline until now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #1010 by calling Catch2's
reportFatal()in thestd::terminatehandler so that failure logging is generated before the process exits.