Fixes regressions - #1009
Merged
Merged
Conversation
Ben Kuhn (BenJKuhn)
approved these changes
Sep 1, 2021
Collaborator
Author
|
Confirmed all tests have run and passed. |
Contributor
|
What task tracks fixing the tests/CI pipeline to detect crashes as failures? |
Collaborator
Author
|
There isn't anything. Unfortunately, we don't have any budget for improving the build but it would be nice to get this fixed. |
Contributor
Contributor
|
Also sorry for introducing the silent failures in the first place... I had some confusion about how Catch2 deals with tests that validate exception throwing and mistakenly believed that running with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PRs introduced bugs. The CI build didn't catch them because the tests just crashed, leaving them undetected.
#1008 had a change to consuming events but the test threw an exception on the producing side which has never been supported. This removes those tests. Charles Milette (@sylveon)
#992 never worked as intended. David Fields (@dfields-msft)