Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Fix failing tests in BotBuilder-Java-4.0-daily-yaml#1500

Merged
tracyboehrer merged 40 commits intomainfrom
bruce/javadocfix11-22e
Dec 6, 2022
Merged

Fix failing tests in BotBuilder-Java-4.0-daily-yaml#1500
tracyboehrer merged 40 commits intomainfrom
bruce/javadocfix11-22e

Conversation

@BruceHaley
Copy link
Copy Markdown
Contributor

@BruceHaley BruceHaley commented Dec 3, 2022 •
edited
Loading

Fixes #minor

Description

Various tests have started failing intermittently apparently because some external change has made the relative timing less consistent. Adding delays to 2 tests seems to have fixed them. I have only succeeded in reducing failures in the 3rd test: In 8 trials it has failed twice.

Details

  • Fix failing test qnaMakerTraceActivity by adding a delay.
  • Fix intermittent errors in 3 OAuthPromptTimesOut_* tests by adding a delay to PromptTimeoutEndsDialogTest.
  • Reduce intermittent errors in testDateLogUpdateActivities by adding delays.
  • Add a "skip" in the pom file to control javadoc compilation. Though javadoc errors are occurring, they do not fail the builds, so I have left the "skip" value set to false to let javadoc continue to run.
  • Add test names to some logs so you can see which tests are logging which output.

Bruce Haley added 30 commits November 22, 2022 16:34
Add maven-javadoc-plugin skip (605)
8380cf2
Add maven-javadoc-plugin skip (217)
918fa72
Add maven-javadoc-plugin skip (158)
5ec217d
Undo 2 skips, keep the one at 605
7c81cea
Add Publish surefire-reports to artifacts
f1b917e
Tweak publish surefire
7ac43a2
Try timeout 1 ms instead of 0
5cda22c
Add .delay(500) to qnaMakerTraceActivity()
6496287
Try timeout 10 ms instead of 1
29ea16b
Disable QnAMakerTests
beacdad
Disable 2 OAuthPromptTimesOut_ tests
d9c5591
Disable another OAuthPromptTimesOut_ test
3c1ef3d
Add back 1 QnAMakerTests test
cb49a39
Cleanup
b09a67c
Try no longer skipping javadoc
5f9c2eb
Add back the .send delay
9c0e7ad
Run QnAMakerTests with debug logging
5feeb49
Pring method names
544fa50
Add PrintMethodName()
840ae07
Trying console writes
d220ac9
Clean up PrintMethodName
c26ba1e
Switch back to System.out.println
c744d91
Clean up PrintMethodName 2
59c5b8c
Uncomment assertEquals("BaseCamp:
6bd9e3e
Turn debug off
c34960f
PrintMethodName tweak
f6538df
Back to <include>**/*Test*.java
d765fac
Re-enable OAuthPromptTimesOut_ tests
2c8c485
Delete log file
00d8475
Try adding a delay to PromptTimeoutEndsDialogTest
1c2e867
@BruceHaley BruceHaley marked this pull request as ready for review December 3, 2022 02:13
@BruceHaley BruceHaley requested a review from a team as a code owner December 3, 2022 02:13
@BruceHaley BruceHaley mentioned this pull request Dec 3, 2022
Closed
@tracyboehrer tracyboehrer merged commit 05c7438 into main Dec 6, 2022
@tracyboehrer tracyboehrer deleted the bruce/javadocfix11-22e branch December 6, 2022 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BruceHaley @tracyboehrer