Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Fix failing tests in BotBuilder-Java-4.0-daily-yaml#1499

Closed
BruceHaley wants to merge 30 commits intomainfrom
bruce/javadocfix11-22d
Closed

Fix failing tests in BotBuilder-Java-4.0-daily-yaml#1499
BruceHaley wants to merge 30 commits intomainfrom
bruce/javadocfix11-22d

Conversation

@BruceHaley
Copy link
Copy Markdown
Contributor

@BruceHaley BruceHaley commented Dec 1, 2022 •
edited
Loading

Fixes #minor

Description

  • Fix failing test: [ERROR] qnaMakerTraceActivity(com.microsoft.bot.ai.qna.QnAMakerTests)
    org.junit.ComparisonFailure: expected:<[echo:how do I clean the stove?]> but was:<[bar]>
    --by adding a delay to qnaMakerTraceActivity.
  • Fix intermittent OAuthPromptTimesOut_* test errors by adding a delay to PromptTimeoutEndsDialogTest.
  • Add test names to the logging so you can see which test output belongs to which tests.

Bruce Haley added 29 commits November 22, 2022 16:34
Add maven-javadoc-plugin skip (605)
8380cf2
Add maven-javadoc-plugin skip (217)
918fa72
Add maven-javadoc-plugin skip (158)
5ec217d
Undo 2 skips, keep the one at 605
7c81cea
Add Publish surefire-reports to artifacts
f1b917e
Tweak publish surefire
7ac43a2
Try timeout 1 ms instead of 0
5cda22c
Add .delay(500) to qnaMakerTraceActivity()
6496287
Try timeout 10 ms instead of 1
29ea16b
Disable QnAMakerTests
beacdad
Disable 2 OAuthPromptTimesOut_ tests
d9c5591
Disable another OAuthPromptTimesOut_ test
3c1ef3d
Add back 1 QnAMakerTests test
cb49a39
Cleanup
b09a67c
Try no longer skipping javadoc
5f9c2eb
Add back the .send delay
9c0e7ad
Run QnAMakerTests with debug logging
5feeb49
Pring method names
544fa50
Add PrintMethodName()
840ae07
Trying console writes
d220ac9
Clean up PrintMethodName
c26ba1e
Switch back to System.out.println
c744d91
Clean up PrintMethodName 2
59c5b8c
Uncomment assertEquals("BaseCamp:
6bd9e3e
Turn debug off
c34960f
PrintMethodName tweak
f6538df
Back to <include>**/*Test*.java
d765fac
Re-enable OAuthPromptTimesOut_ tests
2c8c485
Delete log file
00d8475
@BruceHaley BruceHaley requested a review from a team as a code owner December 1, 2022 21:38
@BruceHaley BruceHaley added the Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. label Dec 1, 2022
@BruceHaley BruceHaley changed the title Fix failing test in BotBuilder-Java-4.0-daily-yaml Fix failing tests in BotBuilder-Java-4.0-daily-yaml Dec 1, 2022
@BruceHaley
Copy link
Copy Markdown
Contributor Author

BruceHaley commented Dec 3, 2022

Replaced by #1500 .

@BruceHaley BruceHaley closed this Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tracyboehrer tracyboehrer Awaiting requested review from tracyboehrer

Assignees

No one assigned

Labels

Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BruceHaley