Add separate flag serverMode for server mode#39735
Merged
DanielRosenwasser merged 2 commits intomasterfrom Aug 3, 2020
Merged
Conversation
sheetalkamat
commented
Jul 24, 2020
mjbvz
approved these changes
Jul 28, 2020
amcasey
approved these changes
Jul 29, 2020
Member
amcasey
left a comment
There was a problem hiding this comment.
LGTM. My bikeshedding would be Syntactic, ApproximateSemantic, Semantic for tidier parallelism, but I'm also fine with the current names (unless we call the feature "partial semantic mode", in which case, I think the enum should match).
|
|
||
| private telemetryOnOpenFile(scriptInfo: ScriptInfo): void { | ||
| if (this.syntaxOnly || !this.eventHandler || !scriptInfo.isJavaScript() || !addToSeen(this.allJsFilesForOpenFileTelemetry, scriptInfo.path)) { | ||
| if (this.serverMode !== LanguageServiceMode.Semantic || !this.eventHandler || !scriptInfo.isJavaScript() || !addToSeen(this.allJsFilesForOpenFileTelemetry, scriptInfo.path)) { |
Member
There was a problem hiding this comment.
Probably an issue for a future PR, but I think the assumption here was that syntax server telemetry would be uninteresting. I'm not sure the same is true for the partial semantic server.
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds --serverMode which takes precedence over --syntaxOnly at any time.
Current names: (open to suggestion if we prefer something else)