Renames in servermode per feedback#39883
Conversation
959f1e2 to
d320625
Compare
|
@typescript-bot cherry-pick this to release-4.0 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I've opened #39888 for you. |
Component commits: d320625 Server mode renames as per feedback
|
@mjbvz should we change the TSServer flag as well? Or should we leave it alone and keep the rename as part of the API? |
|
Obviously, I'm fine with the names I suggested, but I'm not stuck to them. |
|
@typescript-bot cherry-pick this to release-4.0 |
|
Heya @sheetalkamat, I've started to run the task to cherry-pick this into |
|
Hey @sheetalkamat, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually. |
|
@typescript-bot cherry-pick this to release-4.0 and LKG |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually. |
|
@amcasey @DanielRosenwasser Ready to merge ? |
#39888) * Cherry-pick PR #39883 into release-4.0 Component commits: d320625 Server mode renames as per feedback e8d798d More renames 508226e Merge branch 'master' into serverModeRename * Update LKG Co-authored-by: Sheetal Nandi <shkamat@microsoft.com> Co-authored-by: typescript-bot <typescript@microsoft.com>
Renames done as pert #39735 (review)
Not sure if its late to do this but here is the PR