Unshallow submodule clones, update submodule ref#20636
Merged
weswigham merged 1 commit intomicrosoft:masterfrom Dec 12, 2017
Merged
Unshallow submodule clones, update submodule ref#20636weswigham merged 1 commit intomicrosoft:masterfrom
weswigham merged 1 commit intomicrosoft:masterfrom
Conversation
sandersn
approved these changes
Dec 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis builds in #20631 failed at the clone stage because it looks like github is no longer allowing the fetching of nonhead commit objects directly. (At least that's what it looks like). This is reproducible locally with a fresh clone of TS by running
git submodule update --init --recursivein that new clone.Updating the offending submodule ref should fix the issue (and our builds) in the near-term, and un-shallowing submodule the clones should hopefully make it not an issue in the longer-term (since if a normal clone fails there are bigger issues).