Support timeouts in the parallel runner#20631
Merged
weswigham merged 2 commits intomicrosoft:masterfrom Jan 8, 2018
Merged
Conversation
ghost
reviewed
Dec 12, 2017
| stackTraceLimit, | ||
| taskConfigsFolder, | ||
| noColor: !cmdLineOptions.colors, | ||
| timeout: testTimeout, |
| const killChild = () => { | ||
| child.kill(); | ||
| console.error(`Worker exceeded timeout ${child.currentTasks && child.currentTasks.length ? `while running test '${child.currentTasks[0].file}'.` : `during test setup.`}`); | ||
| return process.exit(2); |
Member
Author
There was a problem hiding this comment.
Just to punctuate that no code should execute while the process is exiting.
| return; | ||
| } | ||
| finally { | ||
| if (timeout !== undefined) { |
| return process.exit(2); | ||
| } | ||
| case "timeout": { | ||
| if (data.payload.duration === -1) { |
6f709f2 to
35a3805
Compare
mhegazy
approved these changes
Jan 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the parallel runner to timeout tests (and thereby fail) if they exceed the specified timeout (the default 20s for now). @sandersn mentioned wanting this earlier today. On a somewhat related note, our RWC test timeout is probably waaaay too long for how long we expect RWC to take nowadays.
This implements handling of both
timeout=nin jake,--timeout=nin gulp, andthis.timeout(n)in a unittest.