WIN: Rewrite local freetype build script#9354
Closed
Kojoley wants to merge 3 commits intomatplotlib:masterfrom
Closed
WIN: Rewrite local freetype build script#9354Kojoley wants to merge 3 commits intomatplotlib:masterfrom
Kojoley wants to merge 3 commits intomatplotlib:masterfrom
Conversation
Contributor
|
@Kojoley In case you're interested, I did some pretty extensive rewrite on the setup scripts at https://github.com/anntzer/matplotlib/tree/_wip/setupext-rewrite, which works on MSVC2017 but not older versions due to issues with FreeType. |
9b6989e to
97578a7
Compare
Member
Author
|
@anntzer It is a cool work, if mpl have not used custom build layer I would rewrite local freetype build to distutil's build_clib (but actually it is better to use freetype without kerning and antialiasing for tests, so it will produce same result on different versions) |
3cd4be5 to
0aa303c
Compare
These changes should fix some build problems on windows: - Mismatch Python MSVC runtime version and local freetype - `zlib` and `libpng` linking
0aa303c to
ea1c43a
Compare
Closed
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes should fix some build problems on windows:
zlibandlibpnglinking