BLD: Auto-detect PlatformToolset#16401
Merged
anntzer merged 1 commit intomatplotlib:masterfrom Feb 11, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16401 +/- ##
==========================================
- Coverage 80.84% 80.54% -0.30%
==========================================
Files 307 307
Lines 75749 74407 -1342
Branches 9692 9688 -4
==========================================
- Hits 61241 59933 -1308
+ Misses 11969 11934 -35
- Partials 2539 2540 +1
Continue to review full report at Codecov.
|
Instead of using `devenv` (which may be not installed (it is IDE part) or the latest compiler were installed without IDE) modify the project file and change `PlatformToolset` to pick the default version.
7fe521f to
2aee9f8
Compare
Contributor
|
@eric-wieser Can you confirm this works for you? |
tacaswell
approved these changes
Feb 10, 2020
Member
tacaswell
left a comment
There was a problem hiding this comment.
It builds on both azure and appveyor which means this works under both venv and conda (respectively) which is good evidence that it is working correctly.
Contributor
anntzer
approved these changes
Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
devenv(which may be not installed (it is IDE part) orthe latest compiler were installed without IDE) modify the project file
and change
PlatformToolsetto pick the default version.Fixes #16243