Conversation
…atplotlib/gridspec.py and lib/matplotlib/_fontconfig_patterns.py
…atplotlib/gridspec.py and lib/matplotlib/_fontconfig_patterns.py
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
rcomer
left a comment
There was a problem hiding this comment.
Thank you for your contribution @Krrish2512!
The gridspec lines you removed are not actually deprecations, and the deprecations that were in that file were handled at #26885.
| "3.7", message=f"Support for unknown constants " | ||
| f"({prop[0]!r}) is deprecated since %(since)s and " | ||
| f"will be removed %(removal)s.") | ||
| continue |
|
I’m going to close this as #26865 is complete. |
PR summary
This PR removes the deprecated code during the version 3.7 from lib/matplotlib/gridspec.py and lib/matplotlib/_fontconfig_patterns.py
-->
PR checklist