Skip to content

Removed deprecated code from gridspec.py#26885

Merged
QuLogic merged 1 commit intomatplotlib:mainfrom
ananya314:ghc-gridspec-deprecation
Sep 26, 2023
Merged

Removed deprecated code from gridspec.py#26885
QuLogic merged 1 commit intomatplotlib:mainfrom
ananya314:ghc-gridspec-deprecation

Conversation

@ananya314
Copy link
Copy Markdown
Contributor

@ananya314 ananya314 commented Sep 22, 2023

PR summary

This PR removes 3.7-deprecated API code from lib/matplotlib/gridspec.py which is mentioned in the issue here: #26865

PR checklist

@ananya314 ananya314 force-pushed the ghc-gridspec-deprecation branch 2 times, most recently from 954332a to a4e7cb0 Compare September 22, 2023 23:02
@ananya314
Copy link
Copy Markdown
Contributor Author

Just noticed that this is a duplicate of #26884; my mistake! Feel free to close the PR!

Comment thread doc/api/next_api_changes/removals/26885-AD.rst Outdated
Copy link
Copy Markdown
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're comfortable rebasing and squashing this to one commit, please do so. Otherwise, I suggest the person who merges does that.

@ksunden ksunden mentioned this pull request Sep 25, 2023
14 tasks
Co-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@ananya314 ananya314 force-pushed the ghc-gridspec-deprecation branch from 680d95d to a6d0029 Compare September 26, 2023 00:37
@QuLogic QuLogic added this to the v3.9.0 milestone Sep 26, 2023
@QuLogic QuLogic merged commit f69cf6a into matplotlib:main Sep 26, 2023
@ananya314 ananya314 deleted the ghc-gridspec-deprecation branch September 27, 2023 04:00
@rcomer rcomer mentioned this pull request Oct 16, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance mentored: hackathon topic: geometry manager LayoutEngine, Constrained layout, Tight layout

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants