issue: 26871 - Remove SimplePath class from patches.py#26876
Closed
prateetishah wants to merge 10 commits intomatplotlib:mainfrom
Closed
issue: 26871 - Remove SimplePath class from patches.py#26876prateetishah wants to merge 10 commits intomatplotlib:mainfrom
prateetishah wants to merge 10 commits intomatplotlib:mainfrom
Conversation
tacaswell
reviewed
Sep 22, 2023
tacaswell
reviewed
Sep 22, 2023
| @@ -0,0 +1,3 @@ | |||
| Remove Deprecated API | |||
| ~~~~~~~~~~~~~~~~~~~~~~~ | |||
| ``matplotlib.patches.SimplePath`` | |||
Member
There was a problem hiding this comment.
Can you check the deprecation note an copy over the alternative if any?
Member
|
Can you please squash these commits? https://matplotlib.org/devdocs/devel/development_workflow.html#rewrite-commit-history |
…cated We don't need the optional packages and save a little download/install time.
…cated timedeltas make sense
5c6a2d5 to
23f641c
Compare
Vallabh100
approved these changes
Sep 23, 2023
Member
|
The git history here seems to be messy and includes unrelated commits from e.g. #26505, but overwrites their commit messages. We will also need to sort out between this and #26890, which also is doing the same deprecation task (and while that author closed/reopened several PRs, did get the first one as #26875, if we use that as the metric) |
14 tasks
Member
|
Thank you for your efforts here, however we elected to merge another PR that took on this portion of this task. We hope to hear from you again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR removes the deprecated code during the version 3.7 from lib/matplotlib/patches.py which is a sub issue in the parent issues here: #26865
PR checklist