Skip to content

ci: Don't install recommended packages on Ubuntu#26505

Merged
story645 merged 2 commits intomatplotlib:mainfrom
QuLogic:gha-update
Aug 24, 2023
Merged

ci: Don't install recommended packages on Ubuntu#26505
story645 merged 2 commits intomatplotlib:mainfrom
QuLogic:gha-update

Conversation

@QuLogic
Copy link
Copy Markdown
Member

@QuLogic QuLogic commented Aug 12, 2023

PR summary

We don't need the optional packages and can save a little download/install time.

Also, update the WQY ZenHei package name, as apt has been noting it's outdated for a while.

Draft because I need to confirm that we actually don't need any optional things.

PR checklist

@QuLogic QuLogic added the CI: testing CI configuration and testing label Aug 12, 2023
@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Aug 14, 2023

Looking through the results it seems that everything is good. There's just a failure of some font tests because of an outdated cache.

We don't need the optional packages and save a little download/install
time.
@QuLogic QuLogic marked this pull request as ready for review August 14, 2023 18:12
Copy link
Copy Markdown
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if you want this squash merged or regular merged so leaving it for you to self merge.

@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Aug 23, 2023

I'll always prefer regular merge.

@story645 story645 merged commit 0ac170b into matplotlib:main Aug 24, 2023
@QuLogic QuLogic deleted the gha-update branch August 24, 2023 00:17
@QuLogic QuLogic added this to the v3.9.0 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: testing CI configuration and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants