Deprecate imread() reading from URLs#19367
Merged
timhoffm merged 2 commits intomatplotlib:masterfrom Jan 28, 2021
Merged
Conversation
e60a11c to
9302392
Compare
jklymak
reviewed
Jan 27, 2021
| def test_https_imread_smoketest(): | ||
| v = mimage.imread('https://matplotlib.org/1.5.0/_static/logo2.png') | ||
| with _api.suppress_matplotlib_deprecation_warning(): | ||
| v = mimage.imread('https://matplotlib.org/1.5.0/_static/logo2.png') |
Member
There was a problem hiding this comment.
Shouldn't you properly fix this?
Contributor
Author
There was a problem hiding this comment.
The point is that after the removal, reading this just won't involve matplotlib at all (it'll be PIL.Image.open(urllib.request.urlopen(...)), so the whole test will go away.
Member
There was a problem hiding this comment.
oops sorry - I missed what the test was for....
Member
|
I pushed a point release, but feel free to push back if this is really urgent. |
Contributor
Author
|
I don't think we should introduce new deprecation in bugfix releases, so this should either be 3.4.0, or, if it can't make it, 3.5.0. |
jklymak
approved these changes
Jan 27, 2021
Member
jklymak
left a comment
There was a problem hiding this comment.
Seems fine. Feel free to re0milestone if there is a second review
timhoffm
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Replaces #18649, with the suggestion to directly using the Pillow API (#18649 (review)). Closes #18648.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).