Deprecate imread() reading from URLs#18649
Deprecate imread() reading from URLs#18649timhoffm wants to merge 1 commit intomatplotlib:masterfrom
Conversation
96ac787 to
53a1b1f
Compare
|
recyclying to get doc build to rerun... |
53a1b1f to
5b132aa
Compare
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Passing a URL to `~.pyplot.imread()` is deprecated. Please open the URL before | ||
| reading using ``urllib.request.urlopen()``. |
There was a problem hiding this comment.
As part of the standard library, shouldn't this be link-able?
|
The user also has to do a bit more jiggery-pokery than just The documented incantation needs to be I suspect we should also abandon most of the png guessing code and just let pillow infer as much as it wants to. I think this would make our code simpler (as it is almost a completed drop-through to pillow) and make it more functional (it will open things other than png from a url). I am 👍 on deprecating this, but we need to provide more guidance about what to replace it with. |
tacaswell
left a comment
There was a problem hiding this comment.
Needs better docs on path away from imread.
Should probably also have, "Use PIL.image.open(urlopen(url))" as an option too.
|
👍 on the suggestions. Anybody, feel free to amend. I'm not in word-picking mood right now. |
|
close in favour of #19367 |
PR Summary
Closes #18648.