FIX: catch all multi-dim warnings pandas#18101
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Jul 28, 2020
Merged
Conversation
658f4f8 to
f50b414
Compare
QuLogic
approved these changes
Jul 28, 2020
6 tasks
Member
|
Merging on one review, because it fixes CI. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 28, 2020
6 tasks
dopplershift
added a commit
that referenced
this pull request
Jul 29, 2020
…101-on-v3.3.x Backport PR #18101 on branch v3.3.x (FIX: catch all multi-dim warnings pandas)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Pandas emits a warning, which we need to filter in
check_1din order to maintain back-compatibility. They changed the warning type fromDeprecationWarningtoFutureWarning. Its probably overly fussy to filter twice on each type of warning for different pandas versions, so just filter on a generic warning w/ the correct Warning text.Note that CI is present broken because there is a new release of pandas today...
PR Checklist