Fix example code for enabling logging in API change notice#18094
Merged
timhoffm merged 2 commits intomatplotlib:masterfrom Jul 28, 2020
Merged
Fix example code for enabling logging in API change notice#18094timhoffm merged 2 commits intomatplotlib:masterfrom
timhoffm merged 2 commits intomatplotlib:masterfrom
Conversation
`set_level` doesn't exist, and nothing appears without a handler.
timhoffm
reviewed
Jul 28, 2020
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
timhoffm
approved these changes
Jul 28, 2020
Member
|
CI failure is due to pandas changing a warning (#18101); thus unrelated to this PR. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 28, 2020
…n API change notice
QuLogic
added a commit
that referenced
this pull request
Jul 29, 2020
…094-on-v3.3.0-doc Backport PR #18094 on branch v3.3.0-doc (Fix example code for enabling logging in API change notice)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I stumbled across that API change when trying to figure out how to turn on logging. The code as provided does not work at all.
set_leveldoesn't exist ->setLevelPR Checklist