Second attempt at fixing axis inversion (for mpl3.1).#14643
Merged
ivanov merged 1 commit intomatplotlib:v3.1.xfrom Jun 28, 2019
Merged
Second attempt at fixing axis inversion (for mpl3.1).#14643ivanov merged 1 commit intomatplotlib:v3.1.xfrom
ivanov merged 1 commit intomatplotlib:v3.1.xfrom
Conversation
Turns out that the behavior of nonsingular() and limit_range_for_scale() w.r.t. respecting argument order is all over the place, so just re-sort the axis limits after-the-fact.
This was referenced Jun 28, 2019
ivanov
approved these changes
Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that the behavior of nonsingular() and limit_range_for_scale()
w.r.t. respecting argument order is all over the place, so just re-sort
the axis limits after-the-fact.
Closes #14623 (comment).
PR Summary
PR Checklist