Fix axis inversion with loglocator and logitlocator.#14624
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Aug 20, 2019
Merged
Fix axis inversion with loglocator and logitlocator.#14624tacaswell merged 1 commit intomatplotlib:masterfrom
tacaswell merged 1 commit intomatplotlib:masterfrom
Conversation
6 tasks
177164d to
eec8dba
Compare
Contributor
Author
|
release critical: a similar fix already made it to 3.1 in #14623. |
eec8dba to
df9c152
Compare
timhoffm
approved these changes
Aug 11, 2019
Member
timhoffm
left a comment
There was a problem hiding this comment.
Technically correct. The argument for making nonsingular order the values sounds reasonable, but I don't have a complete overview of the consequences.
tacaswell
approved these changes
Aug 19, 2019
Member
tacaswell
left a comment
There was a problem hiding this comment.
modulo CI passing on rebase.
Anyone can merge on clean CI
df9c152 to
0e94bb9
Compare
0e94bb9 to
9bc8097
Compare
tacaswell
added a commit
to jb-leger/matplotlib
that referenced
this pull request
Sep 4, 2019
In matplotlib#14624 we reverted changing the order of the limits to match the input order. Doing the same here for consistency.
tacaswell
added a commit
to jb-leger/matplotlib
that referenced
this pull request
Sep 6, 2019
In matplotlib#14624 we reverted changing the order of the limits to match the input order. Doing the same here for consistency. Sort the limits before comparing. We want to make sure that it works with the values reversed, but do not expect non-singular to preserve the order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Reverts a minor part of #13593 to provide a different fix to #14615 and #14162
I chose to make nonsingular always order its arguments (and thus just change the behavior in the base class, which was only introduced in 3.1, rather than change the behavior of the subclass, which was only introduced in #13593 and not released yet) as that seems more likely to be respected by third-party implementations. On the other hand in #14643 I realized we can't really trust (for now) whether third-party implementations (or our own) do this ordering, so redoing a sort after-the-fact is likely the most robust solution...
The 3.1.x version is at #14623; this PR should not be backported.
PR Checklist