Conversation
|
cbook is public API. We are going to deprecate the deprecation? 😈 |
|
#10735 may be useful here... |
0a35d2a to
9ea3bab
Compare
|
@anntzer Thanks for the hint on #10735. It's an interesting approach. However I think it's a bit overkill for the present case. Likely, very few people will use I've added a deprecation note and think that's enough. |
| ````````````````````````````````````````````````````````````` | ||
|
|
||
| :class:`matplotlib.cbook.deprecation.mplDeprecation` will be removed in | ||
| future versions. It is just an for |
There was a problem hiding this comment.
I assume "It is just an alias for"...
9ea3bab to
351636c
Compare
You mean, like #10716? :) I would also like to see it go away, but I'll leave it to @tacaswell to make the final call. |
|
|
f5dbacd to
1c5c86d
Compare
|
To be on the safe side, I've kept |
| from matplotlib.cbook import ( | ||
| mplDeprecation, dedent, get_label, sanitize_sequence) | ||
| MatplotlibDeprecationWarning, dedent, get_label, sanitize_sequence) | ||
| fom matplotlib.cbook import mplDeprecation # deprecated |
There was a problem hiding this comment.
This can't be right? Should read from instead of fom.
d8a7c80 to
4fd04f9
Compare
4fd04f9 to
c0c33cd
Compare
|
Not to be a pain :-) but I would appreciate if #11297 (which completely gets rid of quite a few of these mplDeprecations, rather than just renaming them; and which is already approved twice) could go in first... |
c0c33cd to
eb0bbfa
Compare
| from matplotlib import _pylab_helpers, interactive | ||
| from matplotlib.cbook import ( | ||
| dedent, deprecated, silent_list, warn_deprecated, _string_to_bool) | ||
| from matplotlib.cbook import mplDeprecation # deprecated |
eb0bbfa to
a1419cc
Compare
|
Thanks @timhoffm ! |
This is just an alias to
MatplotlibDeprecationWarning. Explicitly using the latter is preferred.Is cbook considered public API? If so, we have do add a deprecation cycle for
mplDeprecation.PR Checklist