Proof of concept for deprecation of global non-callables.#10735
Closed
anntzer wants to merge 1 commit intomatplotlib:masterfrom
Closed
Proof of concept for deprecation of global non-callables.#10735anntzer wants to merge 1 commit intomatplotlib:masterfrom
anntzer wants to merge 1 commit intomatplotlib:masterfrom
Conversation
Triggered by the recent discussion on deprecating matplotlib.verbose. This ensures that a deprecation warning is triggered just by trying to access matplotlib.verbose (or importing it). The implementation idea is based on njsmith's metamodule, but without the hacks needed to support Py<3.5. Py3.7+ will provide instance-`__getattr__` on all classes by default, making the `_DeprecatorModuleType` patching unnecessary (but the warning emitter would still need to be implemented, so there is actually fairly limited improvement from that).
e43b222 to
20b2f34
Compare
6 tasks
13 tasks
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by the recent discussion on deprecating matplotlib.verbose.
This ensures that a deprecation warning is triggered just by trying to
access matplotlib.verbose (or importing it). The implementation idea is
based on njsmith's metamodule, but without the hacks needed to support
Py<3.5.
Py3.7+ will provide instance-
__getattr__on all classes by default,making the
_DeprecatorModuleTypepatching unnecessary (but the warningemitter would still need to be implemented, so there is actually fairly
limited improvement from that).
Just putting this here to show that it can be done... attn @jklymak
PR Summary
PR Checklist