Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

Major: rename default container name to localstack-main#107

Merged
whummer merged 1 commit intomasterfrom
major/default-container-name
Nov 15, 2023
Merged

Major: rename default container name to localstack-main#107
whummer merged 1 commit intomasterfrom
major/default-container-name

Conversation

@simonrw
Copy link
Copy Markdown
Contributor

@simonrw simonrw commented Nov 3, 2023

Motivation

Hyphens are not allowed in URLs. When addressing the LocalStack container over a docker network, the container name resolves to the IP address of the container. This is a problem in particular for boto3 which refuses to connect.

Changes

This PR updates usages of localstack_main to localstack-main.

The previous default container name `localstack_main` is not a valid URL, so
we rename the default to `localstack-main`.

See localstack/localstack#9469.
@simonrw simonrw self-assigned this Nov 3, 2023
@simonrw simonrw marked this pull request as ready for review November 15, 2023 12:10
@simonrw simonrw requested a review from whummer November 15, 2023 12:11
Copy link
Copy Markdown
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@whummer whummer merged commit 81d9cd0 into master Nov 15, 2023
@whummer whummer deleted the major/default-container-name branch November 15, 2023 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants