This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Rename default container name to localstack-main#9469
Merged
simonrw merged 2 commits intorelease/v3.0from Nov 2, 2023
Merged
Conversation
c97ddc3 to
85abf31
Compare
b103bc3 to
383295d
Compare
76f2a3e to
de35cb0
Compare
383295d to
2222acc
Compare
de35cb0 to
71c00c3
Compare
71c00c3 to
8c937c6
Compare
alexrashed
approved these changes
Oct 31, 2023
Member
alexrashed
left a comment
There was a problem hiding this comment.
Awesome! It's great to see this change getting over the line! There aren't too many changes necessary, so I think this should be fine, especially if we can prepare our users appropriately and update all our own repos and docs in advance! 🚀 🧹
joe4dev
approved these changes
Oct 31, 2023
Member
joe4dev
left a comment
There was a problem hiding this comment.
LGTM on the LocalStack side 👍
There are some more references in other places to sync:
- https://docs.localstack.cloud/references/configuration/
- CircleCI orb (docs appear auto-generated from our repo): https://circleci.com/developer/orbs/orb/localstack/platform
...
a4a87dc to
b484b3a
Compare
569f152 to
ebaccf6
Compare
19c8422 to
6ff5c4c
Compare
ebaccf6 to
8bc385a
Compare
This was referenced Nov 2, 2023
Merged
localstack-bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 3, 2023
simonrw
added a commit
to localstack-samples/localstack-demo
that referenced
this pull request
Nov 3, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to localstack/localstack-java-utils
that referenced
this pull request
Nov 3, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to localstack-samples/localstack-pro-samples
that referenced
this pull request
Nov 3, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to localstack-samples/localstack-terraform-samples
that referenced
this pull request
Nov 3, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
alexrashed
pushed a commit
that referenced
this pull request
Nov 4, 2023
simonrw
added a commit
to localstack/docs
that referenced
this pull request
Nov 6, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hyphens are not allowed in URLs. When addressing the LocalStack container over a docker network, the container name resolves to the IP address of the container. This is a problem in particular for
boto3which refuses to connect.Changes
Rename
localstack_main->localstack-main