Conversation
|
While not exactly the same, this error in the appveyor log looks similar to the one I got for Pull Request #4052. In both cases a "threads::" test failed even though these tests do not invoke examples/general (at least that's my belief). 1: threads::iterator. |
|
This evening I reread the *.md documents on the libgit2 account, and I came upon the following sentence in CONTRIBUTING.md. "If you use your fork's master branch directly, things can get messy." I must have overlooked this sentence the first time I read these documents, because both my first Pull Request (#4052) and this one were for a commit on my fork's master branch. In order to avoid any messiness I am closing this Pull Request. I will resubmit it tomorrow using a temporary branch in my fork. |
Prior to this fix config_files() examples/general.c would display random / invalid values for Autocorrect in repos with no help.autocorrect defined.
Prior to this fix config_files() did not free its config objects.