Conversation
|
It looks like the Travis CI Build Job #9100.3 failed with a segmentation fault in libgit2_clar. I enclose the relevant lines from the log. 1: threads::basic.... My commit changed only one file -- examples/generate.c, and I'm fairly sure that libgit2_clar doesn't run the examples/generate executable. I also noticed that other Trravis CI Build Jobs for this Pull Request were successful, e.g. #9100.2, where this area of its log looks like 1: threads::basic...S I noticed that Pull Request #4051, which was submitted about an hour before mine, has an identical failure for Build Job #9099.8. Could this segmentation fault be an intermittent bug? Is there perhaps a way to bypass this test so Pull Requests can be processes? |
|
Thanks! 😀 |
According to the comments in the config.h file, git_config_get_string() needs a config snapshot. Added call to git_repository_config_snapshot() to get this snapshot.
Added a "repo" parameter to config_files(), which is used by git_repository_config_snapshot().
I also tested (but did not commit) having git_config_get_int32() use the config snapshot. This worked, and if implemented could eliminate the "repo_path" parameter to config_files().