kolya-rm · kolya-rm · Dec 16, 2025 · Dec 16, 2025 · Dec 16, 2025 · Dec 16, 2025
diff --git a/Sprint-3/1-key-implement/1-get-angle-type.js b/Sprint-3/1-key-implement/1-get-angle-type.js
@@ -8,8 +8,21 @@
 // Then, write the next test! :) Go through this process until all the cases are implemented
 
 function getAngleType(angle) {
-   if (angle === 90) return "Right angle";
-   // read to the end, complete line 36, then pass your test here
+   if (angle === 90) {
+    return "Right angle";
+   }
+   if (angle === 180) {
+    return "Straight angle";
+   }
+   if (angle < 90) {
+    return "Acute angle";
+   }
+   if (angle < 180) {
+    return "Obtuse angle";
+   }
+   if (angle < 360) {
+    return "Reflex angle";
+   }
 }
 
 // we're going to use this helper function to make our assertions easier to read
@@ -44,13 +57,18 @@ assertEquals(acute, "Acute angle");
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
 // ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(obtuse, "Obtuse angle");
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
 // ====> write your test here, and then add a line to pass the test in the function above
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+// ====> write your test here, and then add a line to pass the test in the function above
+const reflex = getAngleType(210);
+assertEquals(reflex, "Reflex angle");
diff --git a/Sprint-3/1-key-implement/2-is-proper-fraction.js b/Sprint-3/1-key-implement/2-is-proper-fraction.js
@@ -8,7 +8,7 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
+    return Math.abs(numerator / denominator) < 1;
 }
 
 // here's our helper again
@@ -41,13 +41,71 @@ assertEquals(improperFraction, false);
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
 // ====> complete with your assertion
+assertEquals(negativeFraction, true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
 // ====> complete with your assertion
+assertEquals(equalFraction, false);
 
 // Stretch:
 // What other scenarios could you test for?
+
+// Negative numerator with absolute value greater than denominator
+// Input: numerator = -5 denominator = 2
+// Target output: false
+// Explanation: The fraction -5/2 is a improper fraction because the absolute value of the numerator (-5) is greater than the denominator (2). The function should return false.
+const negativeGreaterNumerator = isProperFraction(-5, 2);
+assertEquals(negativeGreaterNumerator, false);
+
+// Negative denominator with absolute value greater than numerator
+// Input: numerator = 2 denominator = -5
+// Target output: true
+// Explanation: The fraction 2/-5 is a proper fraction because the numerator (2) is greater than the absolute value of the denominator (-5). The function should return true.
+const negativeGreaterDenominator = isProperFraction(2, -5);
+assertEquals(negativeGreaterDenominator, true);
+
+// Negative denominator with absolute value less than numerator
+// Input: numerator = 5 denominator = -2
+// Target output: false
+// Explanation: The fraction 5/-2 is a improper fraction because the numerator (5) is greater than the absolute value of the denominator (-2). The function should return true.
+const negativeLessDenominator = isProperFraction(5, -2);
+assertEquals(negativeLessDenominator, false);
+
+// Both negative with numerator less in absolute value
+// Input: numerator = -2 denominator = -5
+// Target output: true
+// Explanation: the fraction -2/-5 is a proper fraction because the absolute value of the numerator (-2) less than the absolute value of the denominator (-5).
+const bothNegativeNumeratorLess = isProperFraction(-2, -5);
+assertEquals(bothNegativeNumeratorLess, true);
+
+// Both negative with numerator greater in absolute value
+// Input: numerator = -5 denominator = -2
+// Target output: false
+// Explanation: the fraction -5/-2 is a improper fraction because the absolute value of the numerator(-5) greater than the absolute value of the denominator (-2).
+const bothNegativeNumeratorGreater = isProperFraction(-5, -2);
+assertEquals(bothNegativeNumeratorGreater, false);
+
+// Both negative with equal values
+// Input: numerator = -2 denominator = -2
+// Target output: false
+// Explanation: the fraction -2/-2 is a improper fraction because the numerator(-2) equal to the the denominator (-2).
+const bothNegativeEqual = isProperFraction(-2, -2);
+assertEquals(bothNegativeEqual, false);
+
+// Numerator is zero
+// Input: numerator = 0 denominator = 2
+// Target output: true
+// Explanation: the fraction 0/2 is a proper fraction because the numerator (0) less than the absolute value of the denominator (2).
+const zeroNumerator = isProperFraction(0, 2);
+assertEquals(zeroNumerator, true);
+
+// Denominator is zero
+// Input: numerator = 2 denominator = 0
+// Target output: false
+// Explanation: the fraction 2/0 is a improper fraction because the absolute value of the numerator (2) greater than the denominator (0).
+const zeroDenominator = isProperFraction(2, 0);
+assertEquals(zeroDenominator, false);
diff --git a/Sprint-3/1-key-implement/3-get-card-value.js b/Sprint-3/1-key-implement/3-get-card-value.js
@@ -8,7 +8,27 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
-    if (rank === "A") return 11;
+  const rank = card.slice(0, card.length - 1);
+  switch (rank) {
+    case "2":
+    case "3":
+    case "4":
+    case "5":
+    case "6":
+    case "7":
+    case "8":
+    case "9":
+      return Number(rank);
+    case "10":
+    case "J":
+    case "Q":
+    case "K":
+      return 10;
+    case "A":
+      return 11;
+    default:
+      throw new Error("Invalid card rank");
+  }
 }
 
 // You need to write assertions for your function to check it works in different cases
@@ -25,27 +45,60 @@ function assertEquals(actualOutput, targetOutput) {
 // Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
 // When the function getCardValue is called with this card string as input,
 // Then it should return the numerical card value
-const aceofSpades = getCardValue("A♠");
-assertEquals(aceofSpades, 11);
 
 // Handle Number Cards (2-10):
 // Given a card with a rank between "2" and "9",
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
-const fiveofHearts = getCardValue("5♥");
+const fiveOfHearts = getCardValue("5♥");
+const twoOfHearts = getCardValue("2♥");
+const threeOfHearts = getCardValue("3♥");
+const fourOfHearts = getCardValue("4♥");
+const sixOfHearts = getCardValue("6♥");
+const sevenOfHearts = getCardValue("7♥");
+const eightOfHearts = getCardValue("8♥");
+const nineOfHearts = getCardValue("9♥");
 // ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(fiveOfHearts, 5);
+assertEquals(twoOfHearts, 2);
+assertEquals(threeOfHearts, 3);
+assertEquals(fourOfHearts, 4);
+assertEquals(sixOfHearts, 6);
+assertEquals(sevenOfHearts, 7);
+assertEquals(eightOfHearts, 8);
+assertEquals(nineOfHearts, 9);
 
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
+const tenOfClubs = getCardValue("10♣");
+const jackOfClubs = getCardValue("J♣");
+const queenOfClubs = getCardValue("Q♣");
+const kingOfClubs = getCardValue("K♣");
+assertEquals(tenOfClubs, 10);
+assertEquals(jackOfClubs, 10);
+assertEquals(queenOfClubs, 10);
+assertEquals(kingOfClubs, 10);
 
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
 // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
+const aceOfSpades = getCardValue("A♠");
+assertEquals(aceOfSpades, 11);
 
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+
+const oneOfDiamonds = "1♦";
+const twentyUnoOfDiamonds = "21♦";
+const hundredOfDiamonds = "100♦";
+const catOfDiamonds = "C♦";
+
+getCardValue(oneOfDiamonds);
+getCardValue(twentyUnoOfDiamonds);
+getCardValue(hundredOfDiamonds);
+getCardValue(catOfDiamonds);
diff --git a/Sprint-3/2-mandatory-rewrite/1-get-angle-type.js b/Sprint-3/2-mandatory-rewrite/1-get-angle-type.js
@@ -1,7 +1,20 @@
 function getAngleType(angle) {
   if (angle === 90) return "Right angle";
-  // replace with your completed function from key-implement
-
+  if (angle === 90) {
+    return "Right angle";
+  }
+  if (angle === 180) {
+    return "Straight angle";
+  }
+  if (angle < 90) {
+    return "Acute angle";
+  }
+  if (angle < 180) {
+    return "Obtuse angle";
+  }
+  if (angle < 360) {
+    return "Reflex angle";
+  }
 }
 
 

diff --git a/Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js b/Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
@@ -1,24 +1,24 @@
 const getAngleType = require("./1-get-angle-type");
 
-test("should identify right angle (90°)", () => {
+test("should identify right angle (angle = 90°)", () => {
   expect(getAngleType(90)).toEqual("Right angle");
 });
 
 // REPLACE the comments with the tests
 // make your test descriptions as clear and readable as possible
 
-// Case 2: Identify Acute Angles:
-// When the angle is less than 90 degrees,
-// Then the function should return "Acute angle"
+test("Should identify acute angles (angle < 90°)", () => {
+  expect(getAngleType(45)).toEqual("Acute angle");
+});
 
-// Case 3: Identify Obtuse Angles:
-// When the angle is greater than 90 degrees and less than 180 degrees,
-// Then the function should return "Obtuse angle"
+test("Should identify obtuse angles (90° < angle < 180°)", () => {
+  expect(getAngleType(120)).toEqual("Obtuse angle");
+});
 
-// Case 4: Identify Straight Angles:
-// When the angle is exactly 180 degrees,
-// Then the function should return "Straight angle"
+test("Should identify straight angle (angle = 180°)", () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
 
-// Case 5: Identify Reflex Angles:
-// When the angle is greater than 180 degrees and less than 360 degrees,
-// Then the function should return "Reflex angle"
+test("Should identify reflex angle (180° < angle < 360°)", () => {
+  expect(getAngleType(210)).toEqual("Reflex angle");
+});
diff --git a/Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js b/Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js
@@ -1,6 +1,5 @@
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
-    // add your completed function from key-implement here
+    return Math.abs(numerator / denominator) < 1;
 }
 
 module.exports = isProperFraction;
diff --git a/Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js b/Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js
@@ -4,8 +4,46 @@ test("should return true for a proper fraction", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
 });
 
-// Case 2: Identify Improper Fractions:
+test("Should return false for improper fraction", () => {
+  expect(isProperFraction(3, 2)).toEqual(false);
+});
+
+test("Should return true for a proper negative fraction", () => {
+  expect(isProperFraction(-2, 3)).toEqual(true);
+});
+
+test("Should return false for equal positive numerator and denominator", () => {
+  expect(isProperFraction(2, 2)).toEqual(false);
+});
+
+test("Should return false for a negative improper fraction", () => {
+  expect(isProperFraction(-3, 2)).toEqual(false);
+});
+
+test("Should return true for a proper fraction with negative denominator", () => {
+  expect(isProperFraction(2, -3)).toEqual(true);
+});
 
-// Case 3: Identify Negative Fractions:
+test("Should return false for an improper fraction with negative denominator", () => {
+  expect(isProperFraction(3, -2)).toEqual(false);  
+});
+
+test("Should return true for a proper fraction with both negative parts", () => {
+  expect(isProperFraction(-2, -3)).toEqual(true);
+});
+
+test("Should return false false for an improper fraction with both negative parts", () => {
+  expect(isProperFraction(-3, -2)).toEqual(false);
+});
+
+test("Should return false for negative equal numerator and denominator", () => {
+  expect(isProperFraction(-2, -2)).toEqual(false);
+});
+
+test("Should return true for a fraction with zero numerator", () => {
+  expect(isProperFraction(0, 2)).toEqual(true);
+});
 
-// Case 4: Identify Equal Numerator and Denominator:
+test("Should return false for a fraction with zero denominator", () => {
+  expect(isProperFraction(2, 0)).toEqual(false);
+});
diff --git a/Sprint-3/2-mandatory-rewrite/3-get-card-value.js b/Sprint-3/2-mandatory-rewrite/3-get-card-value.js
@@ -1,5 +1,24 @@
 function getCardValue(card) {
-    // replace with your code from key-implement
-    return 11;
+    const rank = card.slice(0, card.length - 1);
+    switch (rank) {
+      case "2":
+      case "3":
+      case "4":
+      case "5":
+      case "6":
+      case "7":
+      case "8":
+      case "9":
+      case "10":
+        return Number(rank);
+      case "J":
+      case "Q":
+      case "K":
+        return 10;
+      case "A":
+        return 11;
+      default:
+        throw new Error("Invalid card rank");
+    }
 }
 module.exports = getCardValue;