Nikolai Romanov | oct2025-2 | Structuring and testing data | Sprint 3 | 02 Complete Sprint 3 Coursework - #3
Open
kolya-rm wants to merge 94 commits into
Open
Nikolai Romanov | oct2025-2 | Structuring and testing data | Sprint 3 | 02 Complete Sprint 3 Coursework#3kolya-rm wants to merge 94 commits into
kolya-rm wants to merge 94 commits into
Conversation
…ngle-type.js in ket implement sprint 3.
…ey sprint 3 implement part.
…for sprint 3 key implement part.
…or 1-get-angel-type.js in sprint 3 key implement part.
…r sprint 3 key implement part.
…t-angle-type.js sprint 3 key implement part.
…sprint 2 key implement part.
…gle-type.js sprint 2 key implement part.
…oper-fraction.js sprint 3 key implement part.
…on.js sprint 3 key implement part.
…-proper-fraction.js sprint 2 key implement part.
…an denominator in 2-is-proper-fraction.js sprint 3 key implement part.
…e value greater than denominator in 2-is-proper-fraction.js sprint 3 key implement part.
…e value greater than numerator in 2-is-propr-fraction.js sprint 3 key implement part.
…ith the absolute value greater than numerator in 2-is-proper-fraction.js sprint 3 key implement part.
…e value less than numerator in 2-is-proper-fraction.js sprint 3 key implement part.
…tor is less in absolute values in 2-is-proper-fraction.js sprint 3 key implement part.
…umerator value is greater in absolute values in 2-is-proper-fraction.js sprint 3 key implement part.
…nominator in 2-is-proper-fraction.js sprint 3 key implement part.
…ation.js sprint 3 key implement part.
…raction.js sprint 3 key implement part.
…ting the return value for the aces case.
…sing number card ranks.
…ct work in sprint 3 mandatory practice / implement part.
…= 2 in sprint 3 mandatory practice/implement part.
… in 1 except ending 11 in sprint 3 mandatory practice/implement part.
…rs ending in 1 in sprint 3 mandatory practice/implement part.
… in 2 in sprint 3 mandatory practice/implement part.
…rs ending in 2 in sprint 3 mandatory practice/implement part. Fixed tests for number equal 102 and 122.
… in 3 in sprint 3 mandatory practice/implement part.
…rs ending in 3 in sprint 3 mandatory practice/implement part.
…n sprint 3 mandatory practice/implement part. Updated tests messages.
… in sprint 3 mandatory practice/implement part.
…rgument in sprint 3 mandatory practice/implement part. Updated tests messages.
…argument in sprint 3 mandatory practice/implement part.
…t in sprint 3 mandatory practice/implement part
…nt in sprint 3 mandatory practice/implement part.
…gument in sprint 3 mandatory practice/implement part
…argument in sprint 3 mandatory practice/implement part.
- refactored the logic of checking that a password has at least 5 characters; - updated test notation to check a password minimal length.
- implemented the logic of checking that a password has at least 1 english uppercase letter; - updated the test value checking a password minimal length. - added the presence of english uppercase letter checking test.
- implemented the logic of checking that a password has at least 1 english lowercase letter; - updated the test value checking a password minimal length and presence of uppercase letter; - added the presence of english lowercase letter checking test; - fixing some variable names.
- implemented the logic of checking that a password has at least 1 digit; - updated the test values checking a password minimal length and presence of uppercase and lowercase letters; - added the presence of digit checking test; - fixing some variable names.
- implemented the logic of checking that a password has at least 1 non-alphanumeric symbo ("!", "#", "$", "%", ".", "*", "&");
- updated the test values checking a password minimal length and presence of uppercase, lowercase letters and digits;
- added the presence of non-alphanumerical symbols test;
- fixed some indents.
- added the second parameter for the function validatePassword -- array of previously used passwords; - implemented the logic of checking that a password is not contained in the previous passwords array; - updated the tests checking a password minimal length and presence of uppercase, lowercase letters and digits; - added the test cheking the previous passwords array contains the given password.
- added file card-validater.js for function validateCard(cardNumber) and function is exported; - added file card-validator.test.js for tests;
- implemented checking the length of the card number logic; - added the test checks the card number length; - fix the typo in the function name.
- implemented checking the card number contains non-digit characters logic; - added the test checks the card number contains non-digit characters;
- implemented checking the card number digit sum is not less tah 16; - added the test checks the card number digits sum is not less than 16; - fixed logic for the check card number contains only digits; - updated testing card nuber values.
- implemented checking the card number ends in an even digit; - added the test checks the card number ends in an even digit; - updated testing card number values.
- fixed checking the card number ends in an even digit; - added the test checks the card number ends in an even digit;
… stretch investigate part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Answered questions about the find(str, char) function in the stretch investigate part.
Implemented logic and tests using Jest in the stretch investigate part for functions:
Questions