You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR alters the internal behavior of how an IDToken is acquired through compute_engine credentials. Previously, an idtoken was acquired through (basically) the IAM api and impersonation. This credential type shoudl get the id_token from the metadata server. This change alters the source of the token but keeps the IAM signer capability for now.
The token format returned by metadata may include additional fields but in its defaults, is in the same IDToken format provided by the existing IAM credentials signer mechanism. This pr basically ignores one of the exiting parameters provided, additioal_claims=, since that would not work anyway with any credential type.
the impact as i see it shouldn't be much. Existing users on compute would've had to enable the IAM api, grant impersonation and then get an id_token via signing and exchanging. The idtoken would represent the source service account from the GCE instance itself (like what w'ere doing here).
I'm leaving the Signer capability in now since people would be using it to do stuff like signURL...eventually, that shoudl also get deprecated but that'll be for later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yesThis human has signed the Contributor License Agreement.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344
and as a continuation of #347
_ do not merge_
This PR alters the internal behavior of how an IDToken is acquired through
compute_enginecredentials. Previously, an idtoken was acquired through (basically) the IAM api and impersonation. This credential type shoudl get the id_token from the metadata server. This change alters the source of the token but keeps the IAM signer capability for now.The token format returned by metadata may include additional fields but in its defaults, is in the same IDToken format provided by the existing IAM credentials signer mechanism. This pr basically ignores one of the exiting parameters provided,
additioal_claims=, since that would not work anyway with any credential type.