fix compute engine IDTokenCredentials.with_target_audience method - #361
fix compute engine IDTokenCredentials.with_target_audience method#361lmiglio wants to merge 1 commit into
Conversation
| setup( | ||
| name='google-auth', | ||
| version='1.6.3', | ||
| version='1.6.4', |
There was a problem hiding this comment.
We cut separate release PRs to just bump the version and add changelog notes. See #325 for an example.
There was a problem hiding this comment.
OK, sorry, did not know that. I will revert the version to the one present before.
There was a problem hiding this comment.
I squashed the commits in order to have a single commit with the fix (thus avoiding a commit just for reverting the version back, I do not know if this is compliant with your branch strategy). Let me know if there is other I can do. Thanks!
|
cross referencing with PR that'll remove using the iam signing just to get ID tokens on compute... |
…rget_audience method (googleapis#359)
9e72686 to
a84e427
Compare
busunkim96
left a comment
There was a problem hiding this comment.
Thank you for submitting this PR!
|
Superceded by #438 |
Hi everybody,
Here is the PR for this issue: #359
It should be backward compatible and it should not break anything.
I added an integration test of
IDTokenCredentialsandSignerwhere I usedresponsesfor mocking REST responses, I do not know if that is fine.I followed these guidelines.
Hope everything is ok, if not let me know :)