Skip to content

[web-console] Fix flaky log-search highlight race in LogList #6777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blp merged 1 commit into from
Aug 2, 2026
Merged

[web-console] Fix flaky log-search highlight race in LogList #6777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions js-packages/common-ui/src/lib/LogList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,15 @@
// Bring the match into view ONCE per submission. Tracked only on the SearchState fields,
// and the lookup runs `untrack`ed so streaming updates can't re-trigger the scroll — the
// user retains scroll control after the initial jump.
//
// Jumping to a row outside the currently-rendered window makes virtua scroll to an
// *estimated* offset, measure the newly-mounted row, then correct the scroll position —
// that can take several frames, not just one, especially under CI load. A single
// `requestAnimationFrame(paintHighlight)` would race that: if the row isn't mounted yet on
// that frame, `paintHighlight` deletes the highlight and nothing repaints it afterward
// unless a stray `onscroll` happens to fire. Retry every frame until the row lands (or give
// up after MAX_PAINT_RETRY_FRAMES, so a match that never mounts can't spin forever).
const MAX_PAINT_RETRY_FRAMES = 60
$effect(() => {
const pattern = search.pattern
const occ = search.occurrenceIndex
Expand All @@ -139,9 +148,13 @@
// jumped to. They regain auto-scroll by scrolling back to the bottom themselves.
reverseScroll.stickToBottom = false
virtualizer?.scrollToIndex(idx, { align: 'center' })
// virtua mounts the freshly-visible row on the next frame; paint then so the Range is
// created against the new DOM node rather than the previously-cleared one.
requestAnimationFrame(paintHighlight)
let attempts = 0
const tryPaint = () => {
paintHighlight()
const mounted = scrollContainer?.querySelector(`[data-rowindex="${idx}"]`)
if (!mounted && attempts++ < MAX_PAINT_RETRY_FRAMES) requestAnimationFrame(tryPaint)
}
requestAnimationFrame(tryPaint)
})
})

Expand Down
Loading