[web-console] Fix flaky log-search highlight race in LogList - #6777
Merged
Conversation
virtua scrolls to an estimated offset for rows outside the rendered window and mounts the row over several frames, but the post-scroll repaint only scheduled a single requestAnimationFrame — if the row wasn't mounted on that frame, the highlight was dropped with no retry beyond an incidental onscroll. Retry every frame until the row actually mounts (bounded) instead of assuming one frame is enough. PR #6695 papered over this by bumping the test's poll timeout, which didn't fix the underlying race and it flaked again in CI. Signed-off-by: Ben Pfaff <blp@feldera.com>
Contributor
|
If the diagnosis is correct this is a decent fix. Later I will see if I can organize the code better. |
Karakatiza666
approved these changes
Jul 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
virtua scrolls to an estimated offset for rows outside the rendered window and mounts the row over several frames, but the post-scroll repaint only scheduled a single requestAnimationFrame — if the row wasn't mounted on that frame, the highlight was dropped with no retry beyond an incidental onscroll. Retry every frame until the row actually mounts (bounded) instead of assuming one frame is enough.
PR #6695 papered over this by bumping the test's poll timeout, which didn't fix the underlying race and it flaked again in CI.
@Karakatiza666 Claude claims this fixes it and claims that it was able to test it. This is outside the scope of my knowledge, so I really need your judgment on it.