Skip to content

Enable FIPS in CI but not by default in the build. #5488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blp merged 1 commit into from
Jan 22, 2026
Merged

Enable FIPS in CI but not by default in the build. #5488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:

env:
CARGO_FLAGS: "--release --locked --all-targets"
CARGO_FEATURES_BASE: "pubsub-emulator-test,iceberg-tests-fs,iceberg-tests-glue"
CARGO_FEATURES_BASE: "fips,pubsub-emulator-test,iceberg-tests-fs,iceberg-tests-glue"
FELDERA_PLATFORM_VERSION_SUFFIX: ${{ github.sha }}
RUSTC_WRAPPER: sccache
SCCACHE_CACHE_SIZE: ${{ vars.SCCACHE_CACHE_SIZE }}
Expand Down
6 changes: 2 additions & 4 deletions crates/adapters/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ feldera-enterprise = []
iceberg-tests-fs = []
iceberg-tests-glue = []
iceberg-tests-rest = []
fips = ["rustls/fips"]

[dependencies]
feldera-types = { workspace = true }
Expand Down Expand Up @@ -186,6 +187,7 @@ inventory = { workspace = true }
backtrace = { workspace = true }
itertools = { workspace = true }
metrics-process = { version = "2.4.0", default-features = false }
rustls = { workspace = true }
serde_json_path_to_error = { workspace = true }
smallstr = { workspace = true }
dashmap = { workspace = true }
Expand All @@ -201,10 +203,6 @@ ignored = ["num-traits"]

[target.'cfg(target_os = "linux")'.dependencies]
jemalloc_pprof = { workspace = true, features = ["symbolize"] }
rustls = { workspace = true, features = ["fips"] }

[target.'cfg(not(target_os = "linux"))'.dependencies]
rustls = { workspace = true, features = ["aws-lc-rs"] }

[target.'cfg(unix)'.dependencies]
libc = { workspace = true }
Expand Down
11 changes: 2 additions & 9 deletions crates/pipeline-manager/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ awc = { workspace = true, features = ["rustls-0_23", "rustls-0_23-native-roots"]
reqwest = { workspace = true, features = ["json", "rustls-tls-native-roots"] }
cached = { workspace = true }
crossbeam = { workspace = true }
rustls = { workspace = true }

# System interaction
dirs = { workspace = true } # For: discovering home directory
Expand All @@ -105,22 +106,14 @@ tempfile = { workspace = true }
compare = { workspace = true }
sha2 = { workspace = true }

# Cryptography provider (FIPS enabled by default)
# Make sure this is the same rustls version used by other crates in the dependency tree.
# See the `ensure_default_crypto_provider` function at the root of this crate.
[target.'cfg(target_os = "linux")'.dependencies]
rustls = { workspace = true, features = ["fips"] }

[target.'cfg(not(target_os = "linux"))'.dependencies]
rustls = { workspace = true, features = ["aws-lc-rs"] }

[target.'cfg(not(target_env = "msvc"))'.dependencies]
tikv-jemallocator = { workspace = true, features = ["profiling", "unprefixed_malloc_on_supported_platforms"] }

[features]
default = ["postgresql_embedded"]
feldera-enterprise = []
runtime-version = []
fips = ["rustls/fips"]

[build-dependencies]
change-detection = { workspace = true }
Expand Down
Loading