Skip to content

Enable FIPS in CI but not by default in the build. - #5488

Merged
blp merged 1 commit into
mainfrom
fips
Jan 22, 2026
Merged

Enable FIPS in CI but not by default in the build.#5488
blp merged 1 commit into
mainfrom
fips

Conversation

@blp

@blp blp commented Jan 21, 2026

Copy link
Copy Markdown
Member

FIPS doesn't build with GCC >= 14, which means that the build is broken on any recent Fedora release (which only has GCC 14 and 15).

FIPS doesn't build with GCC >= 14, which means that the build is broken
on any recent Fedora release (which only has GCC 14 and 15).

Signed-off-by: Ben Pfaff <blp@feldera.com>
@blp blp self-assigned this Jan 21, 2026
Copilot AI review requested due to automatic review settings January 21, 2026 23:50
@blp blp added the CI/CD label Jan 21, 2026
@blp
blp requested review from gz and removed request for Copilot January 21, 2026 23:50
@blp
blp added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit fad94e5 Jan 22, 2026
25 of 29 checks passed
@blp
blp deleted the fips branch January 22, 2026 21:37
gz added a commit that referenced this pull request Aug 7, 2026
Go is a build dependency of aws-lc-fips-sys, which only enters the dependency graph behind the fips cargo feature. The runtime image compiles pipelines, and the generated pipeline workspace never enables that feature, so nothing the image builds has needed Go since #5488 made FIPS opt-in. The toolchain has been carried since then at 258 MB, and its Ubuntu package ships CVEs that fail the image scan, which is why it came from an upstream tarball and was bumped three times.

Verified by building the image and compiling a pipeline dependency inside it with no go on PATH.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
nmarasoiu pushed a commit to nmarasoiu/feldera that referenced this pull request Aug 12, 2026
Go is a build dependency of aws-lc-fips-sys, which only enters the dependency graph behind the fips cargo feature. The runtime image compiles pipelines, and the generated pipeline workspace never enables that feature, so nothing the image builds has needed Go since feldera#5488 made FIPS opt-in. The toolchain has been carried since then at 258 MB, and its Ubuntu package ships CVEs that fail the image scan, which is why it came from an upstream tarball and was bumped three times.

Verified by building the image and compiling a pipeline dependency inside it with no go on PATH.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants