Skip to content

Hotfix: error in template - #952

Merged
Timofei Larkin (lllamnyp) merged 1 commit into
mainfrom
fix/keycloak-config-parsing
May 16, 2025
Merged

Hotfix: error in template#952
Timofei Larkin (lllamnyp) merged 1 commit into
mainfrom
fix/keycloak-config-parsing

Conversation

@lllamnyp

@lllamnyp Timofei Larkin (lllamnyp) commented May 16, 2025 •
edited by kvaps
Loading

Copy link
Copy Markdown
Member

fix regression introduced by #928

Summary by CodeRabbit

  • Refactor
    • Updated the handling of dashboard configuration values to use YAML-formatted strings instead of parsed objects during processing.
    • Improved processing of external IP configurations by deferring data transformation until template rendering.

@coderabbitai

coderabbitai Bot commented May 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The change modifies the default fallback value used when extracting the "values.yaml" data from the "kubeapps-auth-config" ConfigMap in the "dashboard" release section. The fallback was changed from an empty dictionary (dict) to an empty string ("") before parsing the YAML content. Additionally, in the Helm template for the nginx ingress, the splitting of the expose-external-ips string into a list is deferred from the variable assignment to the point of YAML rendering.

Changes

File(s) Change Summary
packages/core/platform/bundles/paas-full.yaml Changed the default fallback for "values.yaml" extraction from an empty dictionary to an empty string before YAML parsing.
packages/extra/ingress/templates/nginx-ingress.yaml Deferred splitting of expose-external-ips from variable assignment to YAML rendering in the Helm template.

Poem

In the warren of YAML, a change hops through,
From objects to strings, a new point of view.
External IPs wait, split just in time,
Templates now cleaner, in perfect rhyme.
🐇 With a twitch of my nose and a code-savvy cheer,
I celebrate clean merges, with carrots near!

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8a5b91f and 6f55a66.

📒 Files selected for processing (2)
  • packages/core/platform/bundles/paas-full.yaml (1 hunks)
  • packages/extra/ingress/templates/nginx-ingress.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/core/platform/bundles/paas-full.yaml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test
🔇 Additional comments (2)
packages/extra/ingress/templates/nginx-ingress.yaml (2)

3-3: Use empty string as default for expose-external-ips
Changing the fallback from dict to "" ensures $exposeExternalIPs is always a string. This aligns with how splitList expects its input and lets the if check correctly treat a missing value as “no external IPs.”

39-39: Defer splitting until rendering under externalIPs
Moving splitList to the render point keeps the template cleaner, avoids unnecessary parsing when no IPs are provided, and the | nindent 12 ensures proper YAML alignment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai Bot reviewed May 16, 2025
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 404579c and 1802a47.

📒 Files selected for processing (1)
  • packages/core/platform/bundles/paas-full.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test

Comment thread packages/core/platform/bundles/paas-full.yaml Outdated
@lllamnyp
Timofei Larkin (lllamnyp) force-pushed the fix/keycloak-config-parsing branch from 1802a47 to 8a5b91f Compare May 16, 2025 10:30
@lllamnyp
Hotfix: error in template
6f55a66 
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
@lllamnyp
Timofei Larkin (lllamnyp) force-pushed the fix/keycloak-config-parsing branch from 8a5b91f to 6f55a66 Compare May 16, 2025 11:21
@lllamnyp
Timofei Larkin (lllamnyp) deleted the fix/keycloak-config-parsing branch May 16, 2025 11:42
@kvaps Andrei Kvapil (kvaps) mentioned this pull request May 17, 2025
Merged
Andrei Kvapil (kvaps) added a commit that referenced this pull request May 17, 2025
@kvaps
Revert "[ingress] avoid invalid externalIPs when config value is empt…
31b110c 
…y" (#959)

Reverts #957. This was already fixed by
#952
Timofei Larkin (lllamnyp) added a commit that referenced this pull request May 20, 2025
@lllamnyp
Hotfix: error in template (#952)
da2edb3 
Resolves regressions introduced in #928 and #929

(cherry picked from commit c42a502)
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
Timofei Larkin (lllamnyp) pushed a commit that referenced this pull request May 20, 2025
@kvaps @lllamnyp
Revert "[ingress] avoid invalid externalIPs when config value is empt…
209bddb 
…y" (#959)

Reverts #957. This was already fixed by
#952

(cherry picked from commit 31b110c)
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
@lllamnyp Timofei Larkin (lllamnyp) mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@kvaps Andrei Kvapil (kvaps) Awaiting requested review from kvaps kvaps is a code owner
+1 more reviewer
@klinch0 klinch0 klinch0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lllamnyp @klinch0