Skip to content

[platform] refactor dashboard values - #928

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
dashboard-values
May 15, 2025
Merged

[platform] refactor dashboard values#928
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
dashboard-values

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented May 7, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Andrei Kvapil kvapss@gmail.com

Summary by CodeRabbit

  • Refactor
    • Simplified and restructured dashboard release configurations for both full and hosted environments, replacing complex templating and conditional logic with a cleaner merged YAML approach.
    • Default dashboard values are now centrally defined and merged with authentication configuration, streamlining customization and branding.
    • Dependencies on other components are now more explicitly and conditionally managed.
    • Removed support for referencing external values via valuesFrom in HelmRelease manifests.

@coderabbitai

coderabbitai Bot commented May 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

The changes overhaul the Helm release configuration for the "dashboard" component by removing complex inline templating, conditional logic, and manual value merging. Instead, a new helper template provides default dashboard values, which are merged with authentication configuration extracted from a ConfigMap. Dependency declarations are simplified and conditionalized, and the use of valuesFrom is eliminated.

Changes

File(s) Change Summary
packages/core/platform/bundles/paas-full.yaml, packages/core/platform/bundles/paas-hosted.yaml Simplified the dashboard Helm release configuration: removed detailed inline templating, conditional logic, and manual value merging; now merges default dashboard values from a helper template with values from a ConfigMap.
packages/core/platform/templates/_helpers.tpl Added a new Helm template (cozystack.defaultDashboardValues) to define default configuration values for the dashboard, including conditional pod annotations, resource presets, branding, and CSS customizations.
packages/core/platform/templates/helmreleases.yaml Removed the block that rendered valuesFrom entries in HelmRelease manifests, so no valuesFrom section is generated regardless of input.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HelmChart
    participant ConfigMap
    participant HelperTemplate

    User->>HelmChart: Deploy dashboard release
    HelmChart->>ConfigMap: Lookup kubeapps-auth-config, extract values.yaml
    HelmChart->>HelperTemplate: Render defaultDashboardValues
    HelperTemplate-->>HelmChart: Provide default dashboard values
    HelmChart->>HelmChart: Merge ConfigMap values with defaults
    HelmChart-->>User: Deploy with merged values
Loading

Poem

🐇
A dashboard reborn, with configs so neat,
No more tangled values beneath our feet.
Helpers now guide with branding and style,
Merged YAML flows in a single file.
Simpler dependencies, a cleaner view—
Hopping forward, fresh and new!

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between a240c0b and 545e256.

📒 Files selected for processing (4)
  • packages/core/platform/bundles/paas-full.yaml (1 hunks)
  • packages/core/platform/bundles/paas-hosted.yaml (1 hunks)
  • packages/core/platform/templates/_helpers.tpl (1 hunks)
  • packages/core/platform/templates/helmreleases.yaml (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps
[platform] refactor dashboard values
545e256 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps
Andrei Kvapil (kvaps) merged commit 404579c into main May 15, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the dashboard-values branch May 15, 2025 12:16
Timofei Larkin (lllamnyp) added a commit that referenced this pull request May 16, 2025
@lllamnyp
Hotfix: error in template (#952)
c42a502 
Resolves regressions introduced in #928 and #929
@kvaps Andrei Kvapil (kvaps) mentioned this pull request May 17, 2025
Merged
Timofei Larkin (lllamnyp) pushed a commit that referenced this pull request May 20, 2025
@kvaps @lllamnyp
[platform] refactor dashboard values (#928)
246b5c4 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
(cherry picked from commit 404579c)
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
Timofei Larkin (lllamnyp) added a commit that referenced this pull request May 20, 2025
@lllamnyp
Hotfix: error in template (#952)
da2edb3 
Resolves regressions introduced in #928 and #929

(cherry picked from commit c42a502)
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
@lllamnyp Timofei Larkin (lllamnyp) mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
@klinch0 klinch0 Awaiting requested review from klinch0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kvaps