Skip to content

[ci] Use dots in release candidtate versions, as per SemVer - #901

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
use-dots-in-rc
Apr 25, 2025
Merged

[ci] Use dots in release candidtate versions, as per SemVer#901
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
use-dots-in-rc

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Apr 25, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

This change also fixes finalizing release workflow
#890 (comment)

Summary by CodeRabbit

  • Chores
    • Updated release tag validation to require a dot between "rc" and the number (e.g., v0.31.5-rc.1 instead of v0.31.5-rc1).
    • Adjusted error messages to reflect the new release tag format.

@kvaps
[ci] Use dots in release candidtate versions, as per SemVer
a9b2350 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@coderabbitai

coderabbitai Bot commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request updates the regular expression in the .github/workflows/pull-requests-release.yaml file to enforce a new release candidate tag format that includes a dot between "rc" and the number (e.g., vX.Y.Z-rc.1 instead of vX.Y.Z-rc1). The error message and related parsing logic are adjusted to match this updated pattern. No other logic or control flow changes are present.

Changes

File(s) Summary of Changes
.github/workflows/pull-requests-release.yaml Updated regex to require a dot in the release candidate tag (e.g., -rc.1), and adjusted related parsing and error messages accordingly.

Possibly related PRs

Suggested reviewers

  • klinch0
  • lllamnyp

Poem

In the warren where versions hop and play,
A dot now joins "rc" in a brand new way.
Regexes checked, tags now align,
With SemVer rules, oh how divine!
🐇✨ Release hops forward, neat and bright—
Tag your carrots, the format’s right!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai Bot reviewed Apr 25, 2025
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/pull-requests-release.yaml (1)

154-154: Unused version constant
You assign const version = m[1] + (m[2] ?? ''); but never use it afterward. Consider either emitting it via core.setOutput('version', version) if downstream steps need it, or removing this line to avoid dead code.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e1c1461 and a9b2350.

📒 Files selected for processing (1)
  • .github/workflows/pull-requests-release.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test
🔇 Additional comments (3)
.github/workflows/pull-requests-release.yaml (3)

148-148: Verify GitHub context interpolation and quoting
The line correctly pulls in the tag from steps.get_tag.outputs.tag into a JS string. Ensure that single quotes won’t conflict if tags ever include embedded quotes (unlikely here), but overall this is valid.

149-149: Regex correctly enforces dot in rc suffix
The updated pattern /^v(\d+\.\d+\.\d+)(-rc\.\d+)?$/ strictly matches vX.Y.Z or vX.Y.Z-rc.N. This aligns with SemVer and your PR objective to require the dot between rc and the number.

151-151: Error message updated to reflect new format
The failure message now correctly instructs users on the allowed patterns (vX.Y.Z or vX.Y.Z-rc.N), matching your revised regex. Nicely done.

@kvaps
Andrei Kvapil (kvaps) merged commit 108fc64 into main Apr 25, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the use-dots-in-rc branch April 25, 2025 15:01
Timofei Larkin (lllamnyp) pushed a commit that referenced this pull request May 20, 2025
@kvaps @lllamnyp
[ci] Use dots in release candidtate versions, as per SemVer (#901)
b5f0dd8 
This change also fixes `finalizing release` workflow
#890 (comment)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated release tag validation to require a dot between "rc" and the
number (e.g., `v0.31.5-rc.1` instead of `v0.31.5-rc1`).
  - Adjusted error messages to reflect the new release tag format.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit 108fc64)
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
@lllamnyp Timofei Larkin (lllamnyp) mentioned this pull request May 20, 2025
Closed
@coderabbitai coderabbitai Bot mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
@klinch0 klinch0 Awaiting requested review from klinch0
+1 more reviewer
@NickVolynkin Nick Volynkin (NickVolynkin) NickVolynkin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvaps @NickVolynkin