[ci] Fix release branch matching - #800
Conversation
WalkthroughThis pull request updates the GitHub Actions workflow for release management by modifying the regular expression pattern used to validate branch names. The change removes the 'v' prefix from the expected branch naming convention, switching from Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHubActions as GitHub Actions Workflow
Developer->>GitHubActions: Push branch (e.g., release-1.2.3-suffix)
GitHubActions->>GitHubActions: Validate branch name using regex (no 'v' prefix)
alt Branch name matches expected format
GitHubActions->>Developer: Proceed with release management steps
else Branch name invalid
GitHubActions->>Developer: Return error message (expected format: release-X.Y.Z[-suffix])
end
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pull-requests-release.yaml (1)
55-55: Remove Trailing WhitespaceYAMLlint flagged trailing spaces on this line. Removing these extraneous spaces will help maintain clean formatting and avoid linting warnings.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 55-55: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pull-requests-release.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/pull-requests-release.yaml
[error] 55-55: trailing spaces
(trailing-spaces)
🔇 Additional comments (2)
.github/workflows/pull-requests-release.yaml (2)
54-54: Branch Matching Regex UpdatedThe regex now correctly removes the 'v' prefix, enforcing the branch naming format as
release-X.Y.Z[-suffix]. This aligns with the PR objective and should correctly validate release branches.
57-57: Error Message Reflects New Naming ConventionThe error message was updated to match the new format by removing the 'v' prefix. This ensures that users are notified of the expected branch format as
release-X.Y.Z[-suffix]if validation fails.
Summary by CodeRabbit