Skip to content

Revert "[ci] automatically trigger tests in releasing PR" - #900

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
revert-ci
Apr 25, 2025
Merged

Revert "[ci] automatically trigger tests in releasing PR"#900
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
revert-ci

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Apr 25, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Revert #894 due to fact this logic does not trigger checks in pull requests

Summary by CodeRabbit

  • Chores
    • Removed support for manually triggering the pull request release workflow.
    • Simplified release workflow to run automatically only on labeled pull requests.
    • Eliminated the step in the tags workflow that triggered release verification via manual dispatch.

@kvaps
Revert "[ci] automatically trigger tests in releasing PR"
f644bf2 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@coderabbitai

coderabbitai Bot commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

This update modifies two GitHub Actions workflow YAML files. The manual workflow dispatch trigger (workflow_dispatch) and its associated SHA input have been removed from the pull request release workflow. All logic supporting manual runs, including input handling and conditional checkout, has been eliminated. In the tags workflow, the step responsible for programmatically triggering the pull request release workflow via dispatch has also been removed. The workflows now rely solely on automatic triggers and no longer support manual or programmatic dispatch with a custom SHA.

Changes

File(s) Change Summary
.github/workflows/pull-requests-release.yaml Removed workflow_dispatch event, SHA input, and all related logic; simplified job conditionals and checkout.
.github/workflows/tags.yaml Removed the step that triggered the pull-request release workflow via workflow dispatch; deleted related environment variables and script.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub
    participant PullRequestWorkflow
    participant TagsWorkflow

    GitHub->>PullRequestWorkflow: PR opened/labeled "release"
    PullRequestWorkflow->>PullRequestWorkflow: Run workflow (no manual SHA input)

    GitHub->>TagsWorkflow: Tag pushed
    TagsWorkflow->>TagsWorkflow: Run workflow (no dispatch to PR workflow)
Loading

Possibly related PRs

  • cozystack/cozystack#894: Reversed the addition of manual workflow dispatch and SHA input, directly related to the logic removed in this PR.
  • cozystack/cozystack#875: Modified conditional logic in the same pull-requests-release.yaml workflow, indicating related changes to job conditions.

Suggested reviewers

  • lllamnyp
  • klinch0

Poem

🐇
The workflows now are lean and neat,
No more dispatching by hand or by cheat.
PRs and tags, they flow on their own,
Simpler triggers, all manual gone.
The rabbit hops with workflow delight—
Automation’s path is now just right!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93bdf41 and f644bf2.

📒 Files selected for processing (2)
  • .github/workflows/pull-requests-release.yaml (1 hunks)
  • .github/workflows/tags.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/tags.yaml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test
🔇 Additional comments (1)
.github/workflows/pull-requests-release.yaml (1)

19-23: Conditional execution is correct.

The new if filter ensures the “Test Release” job runs only on pull requests labeled release and skips execution when the PR is closed—this preserves the intended behavior after removing the manual workflow_dispatch trigger and still allows the finalize job to run on merge/close events.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps
Andrei Kvapil (kvaps) merged commit e1c1461 into main Apr 25, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the revert-ci branch April 25, 2025 14:50
Timofei Larkin (lllamnyp) pushed a commit that referenced this pull request May 20, 2025
@kvaps @lllamnyp
Revert "[ci] automatically trigger tests in releasing PR" (#900)
3332448 
Revert #894 due to fact this
logic does not trigger checks in pull requests

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Removed support for manually triggering the pull request release
workflow.
- Simplified release workflow to run automatically only on labeled pull
requests.
- Eliminated the step in the tags workflow that triggered release
verification via manual dispatch.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit e1c1461)
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
@lllamnyp Timofei Larkin (lllamnyp) mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
@klinch0 klinch0 Awaiting requested review from klinch0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kvaps